Skip to content

Use determinate-specific input names#330

Draft
heywoodlh wants to merge 1 commit intoDeterminateSystems:mainfrom
heywoodlh:fix-input-conflict
Draft

Use determinate-specific input names#330
heywoodlh wants to merge 1 commit intoDeterminateSystems:mainfrom
heywoodlh:fix-input-conflict

Conversation

@heywoodlh
Copy link

@heywoodlh heywoodlh commented Jan 29, 2026 •
edited by coderabbitai bot
Loading

Motivation

I watch my flake.lock pretty closely and don't like duplicate inputs. This renames generic inputs to something specific to Determinate -- since Determinate doesn't want users overriding nixpkgs.

Here's a snippet from my flake.nix which removes duplicate inputs:

    # TODO: update to upstream input when PR is merged
    determinate-nixpkgs.url = "https://api.flakehub.com/f/pinned/NixOS/nixpkgs/0.2505.811874%2Brev-daf6dc47aa4b44791372d6139ab7b25269184d55/019a3494-3498-707e-9086-1fb81badc7fe/source.tar.gz"; 

    determinate-nix = {
      url = "github:heywoodlh/nix-src/fix-input-conflict";
      inputs.determinate-nixpkgs.follows = "determinate-nixpkgs";
      inputs.flake-parts.follows = "flake-parts";
      inputs.git-hooks-nix.follows = "pre-commit-hooks";
    };
    determinate = {
      url = "github:heywoodlh/determinate/fix-input-conflict";
      inputs.determinate-nixpkgs.follows = "determinate-nixpkgs";
      inputs.determinate-nix.follows = "determinate-nix";
    };

DeterminateSystems/determinate#157 (comment)

Context

Summary by CodeRabbit

  • Chores
    • Updated build configuration and package source references to improve compatibility.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 29, 2026 •
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
📝 Walkthrough

Walkthrough

The PR updates the primary Nixpkgs input in a Nix flake configuration from inputs.nixpkgs to inputs.determinate-nixpkgs, including all corresponding follow relationships, imports, and internal references throughout the configuration.

Changes

Cohort / File(s) Summary
Nixpkgs Input Replacement
flake.nix		 Updated primary Nixpkgs input source from inputs.nixpkgs to inputs.determinate-nixpkgs. Modified follow relationships in flake-parts and git-hooks-nix to reference determinate-nixpkgs. Updated all import statements and inheritance declarations to use the new input source.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • grahamc

Poem

🐰 A flake takes shape with a different root,
From nixpkgs old to determinate shoot,
All paths now follow the newer way,
Configuration blooms fresh today! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically summarizes the main change: renaming generic nixpkgs inputs to determinate-specific input names to avoid conflicts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot reviewed Jan 29, 2026
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
flake.nix (1)

561-567: Documentation example references old input name.

The REPL example still uses inputs.nixpkgs but the input has been renamed to inputs.determinate-nixpkgs. Users following this example after loading the flake will encounter an error.

📝 Proposed fix 
           ```console
           nix repl> :lf NixOS/nix
-          nix-repl> ps = lib.makeComponents { pkgs = import inputs.nixpkgs { crossSystem = "riscv64-linux"; }; }
+          nix-repl> ps = lib.makeComponents { pkgs = import inputs.determinate-nixpkgs { crossSystem = "riscv64-linux"; }; }
           nix-repl> ps

@heywoodlh heywoodlh marked this pull request as draft January 29, 2026 23:07
@heywoodlh heywoodlh force-pushed the fix-input-conflict branch 2 times, most recently from 3218959 to f1ea740 Compare January 29, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@heywoodlh